- ⚠️ Option helpers collapse NULL and sentinel string values.
- ⚠️ Filters may treat real sentinel text as SQL NULL.

1. Open `superset-frontend/src/utils/common.ts` and note `optionValue` at lines 87-93 and
`optionFromValue` at lines 96-98: `optionValue` returns `NULL_STRING()` when `opt ===
null`, and `optionFromValue` uses this as the `value` field of `OptionItem`.

2. In a TypeScript runtime (or unit test), import `optionFromValue` and `NULL_STRING` from
`superset-frontend/src/utils/common.ts` (re-exported at lines 27-35) and evaluate:

   ```ts

   const a = optionFromValue(null); // uses optionValue/optionLabel

   const b = optionFromValue(NULL_STRING()); // pass a real string equal to the null token

- ⚠️ NULL and empty tokens ignore active request locale.
- ⚠️ Frontend and backend NULL sentinels diverge across locales.

1. Open `superset/constants.py` and note at lines 24-31 that `gettext` is imported as `__`
and immediately invoked to define `NULL_STRING = __("<NULL>")` and `EMPTY_STRING =
__("<empty string>")`, so these translations are resolved once at module import time.

2. In a Flask context, demonstrate locale sensitivity by comparing:

   - `from flask_babel import gettext as __; __("<NULL>")` executed inside a
   `force_locale("fr")` block (returns French translation), versus

   - `from superset.constants import NULL_STRING; NULL_STRING` inside the same block
   (still returns the value computed when `superset.constants` was first imported,
   typically English), proving `NULL_STRING` is not per-request localized.

3. Open `superset/utils/pandas_postprocessing/pivot.py` and observe `pivot()` at lines
10-32, where the `column_fill_value` default is `NULL_STRING` (line 17-31 comment). When a
chart query uses the pivot post-processing operation (wired via
`superset/utils/pandas_postprocessing/__init__.py:17-31` and the generic post-processing
pipeline), any missing column labels are filled with this frozen constant, so users on
non-default locales see the startup-locale token instead of a value in their active
locale.

4. Open `superset/models/helpers.py` around lines 2520-2533 and note `handle_single_value`
compares incoming filter values against `NULL_STRING` and `EMPTY_STRING` (lines 2520-2523)
to turn those sentinel strings back into `None` or `""`. On the frontend, the
corresponding constants are defined in
`superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:32-35` as functions
`NULL_STRING()`/`EMPTY_STRING()` that call `t('<NULL>')`/`t('<empty string>')` per current
UI locale. Because the backend constants are frozen at import time, for users whose locale
differs from the server's startup locale the frontend's localized sentinel strings may no
longer equal the backend's `NULL_STRING`/`EMPTY_STRING`, causing null/empty filters not to
be recognized and desynchronizing frontend and backend sentinel handling across locales.

This is a comment left during a code review.

**Path:** superset/constants.py
**Line:** 24:31
**Comment:**
	*Logic Error: `gettext` is being executed at module import time, so these translated constants are resolved once (typically in the default locale) and then reused for all requests. That breaks per-user localization and can also desynchronize frontend/backend sentinel values across locales. Use lazy translation (or translate at usage time) so the value is resolved in the active request locale.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix

- ⚠️ Bubble chart merges 0-category into null legend bucket.
- ⚠️ Bubble legend mislabels falsy category values as null.

1. In the frontend, `MainPreset` registers `EchartsBubbleChartPlugin` with key
`VizType.Bubble` at `superset-frontend/src/visualizations/presets/MainPreset.ts:198`,
which pulls `BubbleTransformProps` from `@superset-ui/plugin-chart-echarts` (re-exported
in `superset-frontend/plugins/plugin-chart-echarts/src/index.ts:11` as the default from
`./Bubble/transformProps`).

2. Prepare bubble chart form data similar to the unit test
(`superset-frontend/plugins/plugin-chart-echarts/test/Bubble/transformProps.test.ts:10-33`),
but use a dataset where the grouping column (e.g. `entity`/`customer_name`) contains a
legitimate falsy value such as `0` or `''` for one row in `queriesData[0].data` (see
structure at lines 35-58 in that test).

3. When `transformProps` runs in
`superset-frontend/plugins/plugin-chart-echarts/src/Bubble/transformProps.ts:98-169`, it
iterates `data.forEach(datum => { ... })` at line 146, computes `dataName = bubbleSeries ?
datum[bubbleSeries] : datum[entity];` at line 147, and for the row where `datum[entity]`
is `0` or `''`, `dataName` is that falsy value.

4. At line 148, `const name = dataName ? String(dataName) : NULL_STRING();` treats
`0`/`''` as falsy, so `name` becomes `NULL_STRING()` instead of `'0'`/`''`, and the
legend/series name added at lines 151-169 uses the null label; this collapses the real
`0`/empty-string category into the `<NULL>` bucket, producing incorrect legend entries and
color grouping for that category.

This is a comment left during a code review.

**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Bubble/transformProps.ts
**Line:** 148:148
**Comment:**
	*Falsy Zero Check: The null fallback uses a truthy check, so valid category values like `0`, `false`, and `''` are incorrectly converted to the null label. This will merge distinct categories into the null bucket and produce incorrect legend/color grouping. Check explicitly for `null`/`undefined` instead of falsy values.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix

- ⚠️ Treemap drill-to-detail misfilters literal 'null' category.
- ⚠️ Treemap drill-by filters mis-target literal 'null' values.

1. `MainPreset` wires `EchartsTreemapChartPlugin` into the visualization registry with key
`VizType.Treemap` at `superset-frontend/src/visualizations/presets/MainPreset.ts:125`, and
the plugin uses `EchartsTreemap` from
`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx` as its
React chart component.

2. In `Treemap` transform props
(`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/transformProps.ts:170-187`),
leaf node names are derived via `formatSeriesName(...)`; when the underlying groupby
column holds the literal string `"null"`, `formatSeriesName` (see
`superset-frontend/plugins/plugin-chart-echarts/src/utils/series.ts:41-72`) returns
`"null"` unchanged because it only special-cases `name === null || name === undefined`.

3. During rendering, ECharts supplies `treePathInfo` to event handlers and
`extractTreePathInfo`
(`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/constants.ts:27-36`) builds
`treePath` from `pathInfo.name`, so the click/contextmenu handlers in `EchartsTreemap`
receive `treePath` elements equal to `"null"` for those categories.

4. On context menu (right-click) in `EchartsTreemap` at
`superset-frontend/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx:117-155`,
the handler iterates `treePath.forEach((path, i) => { ... })` and executes `const val =
path === 'null' ? NULL_STRING() : path;` at line 127; for a real `"null"` category this
coerces `val` to `NULL_STRING()` (e.g. `<NULL>`), so the `drillToDetailFilters` and
`drillByFilters` built at lines 128-137 use `<NULL>` instead of `"null"` as the filter
value, causing drill-to-detail/drill-by requests to target the null token rather than the
actual `"null"` string rows.

This is a comment left during a code review.

**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Treemap/EchartsTreemap.tsx
**Line:** 127:127
**Comment:**
	*Incorrect Condition Logic: Mapping the literal string `'null'` to the null token changes semantics for real string values equal to `"null"`, so drill filters can target the wrong records. Preserve the original value unless you can reliably detect an actual null sentinel from the source data.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix

- ⚠️ Waterfall x-axis mislabels 0 or empty categories.
- ⚠️ Waterfall chart groups falsy categories into null bucket.

1. `MainPreset` registers `EchartsWaterfallChartPlugin` with key `VizType.Waterfall` in
`superset-frontend/src/visualizations/presets/MainPreset.ts:169-171`, and
`@superset-ui/plugin-chart-echarts` re-exports `WaterfallTransformProps` from
`superset-frontend/plugins/plugin-chart-echarts/src/index.ts:12` pointing to
`./Waterfall/transformProps`.

2. The unit test
`superset-frontend/plugins/plugin-chart-echarts/test/Waterfall/transformProps.test.ts:24-40`
shows how `transformProps` is invoked via `ChartProps` with `queriesData[0].data` and
formData specifying `x_axis` and `metric`; to reproduce the issue, use a similar setup but
include a row in `data` where the x-axis column (e.g. `year`) is a legitimate falsy value
like `0` or `''`.

3. When `transformProps` executes in
`superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/transformProps.ts:159-231`,
it builds `transformedData` via `transformer` (lines 224-231) and then computes
`xAxisData` at lines 323-339 by mapping each `row` to an x-axis label; for each row it
sets `value = row[xAxisName]` or `row[breakdownName]` and then reaches the block at lines
331-333.

4. At line 331, `if (!value) { value = NULL_STRING(); }` treats any falsy `value` as null,
so a legitimate x-axis value of `0`, `false`, or `''` is converted to `NULL_STRING()`
instead of remaining `0`/`false`/`''`, and the resulting x-axis categories (used in
`echartOptions.xAxis.data` at line 446) and tooltip/title formatter `xAxisFormatter`
(lines 341-351) mislabel these categories as `<NULL>`, merging them into the null bucket
and breaking category labeling and grouping.

This is a comment left during a code review.

**Path:** superset-frontend/plugins/plugin-chart-echarts/src/Waterfall/transformProps.ts
**Line:** 331:333
**Comment:**
	*Falsy Zero Check: This condition treats all falsy x-axis values as null, so legitimate values like `0` become `<NULL>`. That breaks category labeling and can produce wrong axis formatting/grouping. Restrict the null substitution to `null`/`undefined` (and handle empty string separately if needed).

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix